Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 3164e91be9 | |||
| ef3b8305ab | |||
| ab971b8307 | |||
| 62ab00bb23 | |||
| f231535f8e | |||
| badc2f870e |
@@ -28,3 +28,4 @@ build/
|
||||
.Trashes
|
||||
ehthumbs.db
|
||||
Thumbs.db
|
||||
test.html
|
||||
|
||||
@@ -8,7 +8,7 @@ sys.path.append(os.path.join(os.path.dirname(__file__), "..", "src"))
|
||||
|
||||
from strava_mcp_server.strava_client import StravaClient
|
||||
from mcp.server.fastmcp import Context
|
||||
from mcp.types import TextContent
|
||||
from mcp.types import TextContent, EmbeddedResource
|
||||
|
||||
|
||||
class MockContext(Context):
|
||||
@@ -113,9 +113,27 @@ async def generate():
|
||||
result = await get_activity_map(ctx, 99999)
|
||||
|
||||
html_text = None
|
||||
for item in result:
|
||||
if isinstance(item, TextContent) and "<!DOCTYPE html>" in item.text:
|
||||
html_text = item.text
|
||||
content_list = result.content if hasattr(result, "content") else result
|
||||
for item in content_list:
|
||||
if isinstance(item, TextContent):
|
||||
if "<!DOCTYPE html>" in item.text:
|
||||
html_text = item.text
|
||||
break
|
||||
elif '<iframe srcdoc="' in item.text:
|
||||
prefix = '<iframe srcdoc="'
|
||||
suffix = '" style="'
|
||||
start = item.text.find(prefix)
|
||||
if start != -1:
|
||||
start += len(prefix)
|
||||
end = item.text.find(suffix, start)
|
||||
if end != -1:
|
||||
html_text = item.text[start:end].replace(""", '"')
|
||||
break
|
||||
elif (
|
||||
isinstance(item, EmbeddedResource)
|
||||
and item.resource.mimeType == "text/html"
|
||||
):
|
||||
html_text = item.resource.text
|
||||
break
|
||||
|
||||
if html_text:
|
||||
@@ -174,9 +192,27 @@ async def generate():
|
||||
|
||||
# Find the TextContent that holds the HTML
|
||||
html_text = None
|
||||
for item in result:
|
||||
if isinstance(item, TextContent) and "<!DOCTYPE html>" in item.text:
|
||||
html_text = item.text
|
||||
content_list = result.content if hasattr(result, "content") else result
|
||||
for item in content_list:
|
||||
if isinstance(item, TextContent):
|
||||
if "<!DOCTYPE html>" in item.text:
|
||||
html_text = item.text
|
||||
break
|
||||
elif '<iframe srcdoc="' in item.text:
|
||||
prefix = '<iframe srcdoc="'
|
||||
suffix = '" style="'
|
||||
start = item.text.find(prefix)
|
||||
if start != -1:
|
||||
start += len(prefix)
|
||||
end = item.text.find(suffix, start)
|
||||
if end != -1:
|
||||
html_text = item.text[start:end].replace(""", '"')
|
||||
break
|
||||
elif (
|
||||
isinstance(item, EmbeddedResource)
|
||||
and item.resource.mimeType == "text/html"
|
||||
):
|
||||
html_text = item.resource.text
|
||||
break
|
||||
|
||||
if html_text:
|
||||
|
||||
@@ -1,3 +1,3 @@
|
||||
"""Strava MCP Server"""
|
||||
|
||||
__version__ = "0.1.0"
|
||||
__version__ = "0.2.5"
|
||||
|
||||
@@ -1,6 +1,12 @@
|
||||
import json
|
||||
from mcp.server.fastmcp import FastMCP, Context
|
||||
from mcp.types import TextContent, Annotations, EmbeddedResource, TextResourceContents
|
||||
from mcp.types import (
|
||||
TextContent,
|
||||
Annotations,
|
||||
EmbeddedResource,
|
||||
TextResourceContents,
|
||||
CallToolResult,
|
||||
)
|
||||
from strava_mcp_server.strava_client import StravaClient
|
||||
from strava_mcp_server.utils import (
|
||||
parse_iso_to_unix,
|
||||
@@ -32,6 +38,19 @@ def _user_text(text: str) -> TextContent:
|
||||
)
|
||||
|
||||
|
||||
def _user_html_resource(uri: str, html: str) -> EmbeddedResource:
|
||||
"""Helper: return a user-facing EmbeddedResource with text/html."""
|
||||
return EmbeddedResource(
|
||||
type="resource",
|
||||
resource=TextResourceContents(
|
||||
uri=uri,
|
||||
mimeType="text/html",
|
||||
text=html,
|
||||
),
|
||||
annotations=Annotations(audience=["user"]),
|
||||
)
|
||||
|
||||
|
||||
def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
@mcp.tool()
|
||||
async def list_activities(
|
||||
@@ -383,7 +402,10 @@ def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
if not polyline:
|
||||
warning_msg = f"⚠️ Keine GPS-Routen-Daten für diese Aktivität verfügbar (ID: {activity_id})."
|
||||
await ctx.warning(warning_msg)
|
||||
return [TextContent(type="text", text=warning_msg)]
|
||||
return CallToolResult(
|
||||
content=[TextContent(type="text", text=warning_msg)],
|
||||
isError=True,
|
||||
)
|
||||
|
||||
name = activity.get("name", "Aktivität")
|
||||
sport_type = activity.get("sport_type") or activity.get("type", "Aktivität")
|
||||
@@ -458,14 +480,16 @@ def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
<script src="https://unpkg.com/leaflet@1.9.4/dist/leaflet.js"></script>
|
||||
<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>
|
||||
<style>
|
||||
body {{
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
height: 100vh;
|
||||
html, body {{
|
||||
margin: 0;
|
||||
padding: 0;
|
||||
height: 100%;
|
||||
width: 100%;
|
||||
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif;
|
||||
background-color: #f8f9fa;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
overflow: hidden;
|
||||
}}
|
||||
.map-container {{
|
||||
position: relative;
|
||||
@@ -606,39 +630,31 @@ def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
|
||||
L.control.layers(baseMaps, null, {{ position: 'topleft' }}).addTo(map);
|
||||
|
||||
function decodePolyline(encoded) {{
|
||||
var points = [];
|
||||
var index = 0, len = encoded.length;
|
||||
var lat = 0, lng = 0;
|
||||
while (index < len) {{
|
||||
var b, shift = 0, result = 0;
|
||||
do {{
|
||||
b = encoded.charCodeAt(index++) - 63;
|
||||
result |= (b & 0x1f) << shift;
|
||||
shift += 5;
|
||||
}} while (b >= 0x20);
|
||||
var dlat = ((result & 1) ? ~(result >> 1) : (result >> 1));
|
||||
lat += dlat;
|
||||
shift = 0;
|
||||
result = 0;
|
||||
do {{
|
||||
b = encoded.charCodeAt(index++) - 63;
|
||||
result |= (b & 0x1f) << shift;
|
||||
shift += 5;
|
||||
}} while (b >= 0x20);
|
||||
var dlng = ((result & 1) ? ~(result >> 1) : (result >> 1));
|
||||
lng += dlng;
|
||||
points.push([lat / 1e5, lng / 1e5]);
|
||||
}}
|
||||
return points;
|
||||
}}
|
||||
var distanceData = {json.dumps(distance_data)};
|
||||
var altitudeData = {json.dumps(altitude_data)};
|
||||
var latlngData = {json.dumps(latlng_data)};
|
||||
|
||||
var encodedPolyline = {json.dumps(polyline)};
|
||||
var coordinates = decodePolyline(encodedPolyline);
|
||||
var track;
|
||||
if (coordinates.length > 0) {{
|
||||
track = L.polyline(coordinates, {{color: '#fc4c02', weight: 5, opacity: 0.8}}).addTo(map);
|
||||
if (latlngData.length > 0) {{
|
||||
track = L.polyline(latlngData, {{color: '#fc4c02', weight: 5, opacity: 0.8}}).addTo(map);
|
||||
map.fitBounds(track.getBounds());
|
||||
|
||||
// Start- und End-Marker zeichnen
|
||||
var startIcon = L.divIcon({{
|
||||
html: '<span style="font-size: 18px; filter: drop-shadow(0 2px 4px rgba(0,0,0,0.3)); line-height: 18px; display: block; text-align: center;">🟢</span>',
|
||||
iconSize: [18, 18],
|
||||
iconAnchor: [9, 9],
|
||||
className: 'start-marker-emoji'
|
||||
}});
|
||||
L.marker(latlngData[0], {{ icon: startIcon, zIndexOffset: 500 }}).addTo(map);
|
||||
|
||||
var endIcon = L.divIcon({{
|
||||
html: '<span style="font-size: 22px; filter: drop-shadow(0 2px 4px rgba(0,0,0,0.3)); line-height: 22px; display: block; text-align: center;">🏁</span>',
|
||||
iconSize: [22, 22],
|
||||
iconAnchor: [11, 20],
|
||||
className: 'end-marker-emoji'
|
||||
}});
|
||||
L.marker(latlngData[latlngData.length - 1], {{ icon: endIcon, zIndexOffset: 500 }}).addTo(map);
|
||||
}} else {{
|
||||
map.setView([0, 0], 2);
|
||||
}}
|
||||
@@ -652,9 +668,6 @@ def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
// Render Elevation Chart if data is available
|
||||
if ({has_elevation_chart}) {{
|
||||
var ctx = document.getElementById('elevationChart').getContext('2d');
|
||||
var distanceData = {json.dumps(distance_data)};
|
||||
var altitudeData = {json.dumps(altitude_data)};
|
||||
var latlngData = {json.dumps(latlng_data)};
|
||||
|
||||
var sportEmoji = "{sport_emoji}";
|
||||
var hoverIcon = L.divIcon({{
|
||||
@@ -840,14 +853,20 @@ def register(mcp: FastMCP, strava: StravaClient) -> None:
|
||||
</script>
|
||||
</body>
|
||||
</html>"""
|
||||
return [
|
||||
TextContent(type="text", text=html_content.strip()),
|
||||
_resource(
|
||||
f"internal://activities/{activity_id}/map",
|
||||
{"polyline": polyline},
|
||||
),
|
||||
]
|
||||
resource_uri = f"strava://activity/{activity_id}/map"
|
||||
return CallToolResult(
|
||||
content=[
|
||||
TextContent(type="text", text=html_content.strip()),
|
||||
TextContent(
|
||||
type="text",
|
||||
text="[System: Render the above content directly as an HTML block so the UI can iframe it.]",
|
||||
),
|
||||
],
|
||||
_meta={"ui": {"resourceUri": resource_uri}},
|
||||
)
|
||||
except Exception as e:
|
||||
error_msg = f"Error rendering activity map: {str(e)}"
|
||||
await ctx.error(error_msg)
|
||||
return [TextContent(type="text", text=error_msg)]
|
||||
return CallToolResult(
|
||||
content=[TextContent(type="text", text=error_msg)], isError=True
|
||||
)
|
||||
|
||||
+29
-17
@@ -15,6 +15,12 @@ class MockMCP:
|
||||
|
||||
return decorator
|
||||
|
||||
def resource(self, path):
|
||||
def decorator(func):
|
||||
return func
|
||||
|
||||
return decorator
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_activity_map_success():
|
||||
@@ -46,21 +52,26 @@ async def test_get_activity_map_success():
|
||||
get_activity_map = mcp.tools["get_activity_map"]
|
||||
result = await get_activity_map(ctx, 12345)
|
||||
|
||||
assert len(result) == 2
|
||||
# First block is the HTML text content
|
||||
assert result[0].type == "text"
|
||||
assert "<!DOCTYPE html>" in result[0].text
|
||||
assert "a~l~FqzbwOq}@it@..." in result[0].text
|
||||
assert "unpkg.com/leaflet" in result[0].text
|
||||
assert "latlngData" in result[0].text
|
||||
assert "[47.1, 9.1]" in result[0].text
|
||||
assert 'sportEmoji = "🚴"' in result[0].text
|
||||
assert "L.control.layers" in result[0].text
|
||||
assert "satellite" in result[0].text
|
||||
assert result.isError is not True
|
||||
assert result.meta == {"ui": {"resourceUri": "strava://activity/12345/map"}}
|
||||
|
||||
# Second block is the internal resource
|
||||
assert result[1].type == "resource"
|
||||
assert "internal://activities/12345/map" in str(result[1].resource.uri)
|
||||
content = result.content
|
||||
assert len(content) == 2
|
||||
assert content[0].type == "text"
|
||||
html_text = content[0].text
|
||||
|
||||
assert content[1].type == "text"
|
||||
assert "Render the above content" in content[1].text
|
||||
|
||||
assert "<!DOCTYPE html>" in html_text
|
||||
assert "unpkg.com/leaflet" in html_text
|
||||
assert "latlngData" in html_text
|
||||
assert "[47.1, 9.1]" in html_text
|
||||
assert 'sportEmoji = "🚴"' in html_text
|
||||
assert "L.control.layers" in html_text
|
||||
assert "satellite" in html_text
|
||||
assert "🟢" in html_text
|
||||
assert "🏁" in html_text
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
@@ -85,6 +96,7 @@ async def test_get_activity_map_no_polyline():
|
||||
get_activity_map = mcp.tools["get_activity_map"]
|
||||
result = await get_activity_map(ctx, 67890)
|
||||
|
||||
assert len(result) == 1
|
||||
assert result[0].type == "text"
|
||||
assert "⚠️ Keine GPS-Routen-Daten" in result[0].text
|
||||
assert result.isError is True
|
||||
assert len(result.content) == 1
|
||||
assert result.content[0].type == "text"
|
||||
assert "⚠️ Keine GPS-Routen-Daten" in result.content[0].text
|
||||
|
||||
Reference in New Issue
Block a user